Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to watch forever #580

Open
skewty opened this issue Jul 8, 2024 · 0 comments
Open

Impossible to watch forever #580

skewty opened this issue Jul 8, 2024 · 0 comments
Assignees
@caspervonb
Labels
defect Suspected defect such as a bug or regression

Comments

@skewty
Copy link

skewty commented Jul 8, 2024 •
edited
Loading

Observed behavior

Both zero and None values are falsey so watching forever becomes impossible.

Expected behavior

Change the check to if inactive_threshold is None: so None gives auto timeout but explicit 0 and 0.0 are accepted and not overriden.

Server and client version

nats-py 2.8.0

nats-server 2.10.17

Host environment

No response

Steps to reproduce

See code line referenced. https://github.com/nats-io/nats.py/blob/981e5d6f0dfa944c8be9b4ee49ffdbd11786742c/nats/js/kv.py#L441C9-L441C34
@skewty skewty added the defect Suspected defect such as a bug or regression label Jul 8, 2024
This was referenced Jul 8, 2024
Open
Open
@caspervonb caspervonb self-assigned this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caspervonb caspervonb

Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caspervonb @skewty