Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMSG header format inconsistency when with HPUB vs with $JS.API.CONSUMER.MSG.NEXT #6134

Open
tolgaulas opened this issue Nov 14, 2024 — with Slack · 1 comment
Open

Comments

Copy link

tolgaulas commented Nov 14, 2024

Hello All, recent Nats-server

[1949268] 2024/11/15 00:24:54.770277 [INF]   Version:  2.10.22
[1949268] 2024/11/15 00:24:54.770280 [INF]   Git:      [240e9a4]
[1949268] 2024/11/15 00:24:54.770282 [INF]   Name:     nats_server_standalone
[1949268] 2024/11/15 00:24:54.770284 [INF]   Node:     YlG2Uy9H
[1949268] 2024/11/15 00:24:54.770285 [INF]   ID:       NBDRMOOE26PKACDIRHUTBMLJPQHLXLTRZT4SUA7KC23GZTCLCARXRQ2U

the $JS.API.CONSUMER.MSG.NEXT response HMSG does not comply with the NATS headers guideline (https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-4.md) which dictates the first line of headers to be exactly NATS/1.0␍␊, all the other HPUB generates conforming this however the consumer.msg.get emits and HMSGNATS/1.0 404 No Messages.. Also packet captured to be sure..

Very confusing.. Any roadmap on that?

Slack Message

@tolgaulas tolgaulas changed the title HMSG header format inconsistency in HMSG when with HPUB vs with $JS.API.CONSUMER.MSG.NEXT HMSG header format inconsistency when with HPUB vs with $JS.API.CONSUMER.MSG.NEXT Nov 14, 2024
@derekcollison
Copy link
Member

We should update the ADR then, since you can have an optional status code and status description before the \r\n.

/cc @ripienaar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants