-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support visual selection for code actions #178
Comments
I think the tricky part is knowing when to check |
Towards #178 Uses a hack to try to figure out if the user is likely to have set reasonable marks for the range and is running from a visual selection so that lines were passed with `:'<,'>LSClientFindCodeActions`.
We could maybe do something like #179 but it's pretty hacky. Alternatively we could add |
I tried
Looks ugly, but works. |
Hello! And thank you for this excellent plugin.
I'm working on my language server and use this plugin in Vim 8. And I can't implement support for code actions, which requires some selection. Example: extract code to function.
This plugin always sends the cursor position for start and cursor + 1 column for end.
It would be nice, that if vim in selection mode it sends proper range.
I don't know viml. I tried to change this code
vim-lsc/autoload/lsc/params.vim
Line 14 in c6d088d
by using
line('v')
.But end position with
line('.')
is wrong.Reference in docs. http://vimdoc.sourceforge.net/htmldoc/eval.html#line()
I would like to help with this, but don't know where to start.
The text was updated successfully, but these errors were encountered: