Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FancyboxButton Storybook stories #41

Open
laespinoza opened this issue Oct 4, 2021 · 2 comments
Open

add FancyboxButton Storybook stories #41

laespinoza opened this issue Oct 4, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request storybook This issue relates to Storybook.js

Comments

@laespinoza
Copy link
Contributor

Adding this issue that came out from this pull request discussion:

  • add a story for the fancybox button and a corresponding fancybox link
@stephiescastle stephiescastle added enhancement New feature or request storybook This issue relates to Storybook.js labels Jan 24, 2022
@stephiescastle
Copy link
Member

I'll work on adding this as part of #105

@stephiescastle stephiescastle self-assigned this Jan 24, 2022
@stephiescastle
Copy link
Member

stephiescastle commented Jan 24, 2022

I decided to tackle this separately from #105. I created a branch that adds a story, but I'm thinking of pushing this off for a later release.

The FancyboxButton template we have and are currently using throughout our templates makes a lot of assumptions under the hood, and trying to document how to use it alongside Fancyapps' own documentation is confusing.

Essentially, users just need to know what data attributes to add to a an HTML element. The names of the data-attributes don't line up with our prop names, and I'm not sure it's worthwhile to rename/restructure everything for this reason. Unfortunately, fancyapps doesn't have great documentation about all of the data attributes that are available for fancybox, so we may want to consider adding our own docs on that, but I don't think it's necessary for the 1.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request storybook This issue relates to Storybook.js
Projects
None yet
Development

No branches or pull requests

2 participants