Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue (using error output) & Always Output Data logic missing in Redis Node #8744

Open
liamdmcgarrigle opened this issue Feb 26, 2024 · 2 comments · May be fixed by #11714
Open

Continue (using error output) & Always Output Data logic missing in Redis Node #8744

liamdmcgarrigle opened this issue Feb 26, 2024 · 2 comments · May be fixed by #11714
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@liamdmcgarrigle
Copy link

liamdmcgarrigle commented Feb 26, 2024

Bug Description

When set to Continue (using error output)

It should be continuing on the error branch, instead it goes through the success branch with no data

Screenshot 2024-02-26 at 5 00 33 PM

When set to Always Output Data

It should continue with error data but it just stops

Screenshot 2024-02-26 at 5 01 03 PM

The Code

There is usually the logic for both of these operations in this catch statement. Instead it is just throwing an error.

Screenshot 2024-02-26 at 5 04 37 PM

To Reproduce

Continue (using error output)

  1. Add a Redis node that will cause an error
  2. Set the redis node to Continue (using error output)
  3. Run the workflow

You'll see it has an error and is continuing on the success branch with no data

Always Output Data

  1. Add a Redis node that will cause an error
  2. Set the redis node to Always Output Data
  3. Run the workflow

You'll see it does not output the data

Expected behavior

Explained in bug description section.

Operating System

Debian 12.5

n8n Version

1.24.1

Node.js Version

18+

Database

SQLite (default)

Execution mode

main (default)

@Joffcom
Copy link
Member

Joffcom commented Feb 26, 2024

Hey @liamdmcgarrigle,

Thanks for the report, there are actually a few nodes without this feature and they are being slowly added as we get to them.

I am not sure if this should be tracked as a bug or not so I will keep this open and I will get a dev ticket created in the morning for this.

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Feb 27, 2024
@Joffcom
Copy link
Member

Joffcom commented Feb 27, 2024

Internal Ticket is NODE-1177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants