Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect password when signing in when making a report returns to start of process with no immediate error #4818

Open
davea opened this issue Jan 29, 2024 · 3 comments

Comments

@davea
Copy link
Member

davea commented Jan 29, 2024

Describe the bug
When making a new report, if the user enters an incorrect password in the "Tell us about you" section and hits "submit" they're taken back to the category selection screen with no visible error message. Clicking back through the form does reveal an error when the user reaches the "Tell us about you" page again.

To Reproduce
Steps to reproduce the behavior:

  1. If signed in, sign out.
  2. Start a new report, and continue through to the "Tell us about you" page.
  3. Select "Or sign in with password to prefill this information."
    image
  4. Enter a valid email address and invalid password, hit submit.
    image
  5. User is taken back to category selection page:
    image
  6. Continue through the reporting form to the "Tell us about you" page and see the error:
    image
@dracos
Copy link
Member

dracos commented Jan 29, 2024

Looks like in 1412ead I put in fixmystreet.js the comment "// XXX Is this still needed, should it be better done server side? Will need to spot multiple pages too" before the code that shows/hides the right user bit of the form. Which I guess is what is the case here! So yes, either the server submission needs to know it's outputting this area and adjust what 'page' is initially shown/hidden in the JS, or this JS chunk needs updating to show the right 'page' when it loads, or at least it should show an error on the initial category page screen so you know to click through.

@lizettal
Copy link

lizettal commented Feb 6, 2024

Could put in an error message as a short term fix but agreed that a full fix is a better idea considering no one has raised this as an issue in three years since the work above was done. Estimated at 2-3 days to put in a fix.

@sallytay
Copy link

sallytay commented Feb 9, 2024

Relates to FD 3820 @sallytay to update the client when needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants