Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different states in around view dropdown compared to reports view dropdown #4442

Open
jonkri opened this issue May 17, 2023 · 3 comments
Open

Comments

@jonkri
Copy link
Contributor

jonkri commented May 17, 2023

Describe the bug

When visiting the around view (by searching from the home page), I see fewer states in the "Show" dropdown (Open, Closed, Fixed, etc.) compared to the same dropdown in the report view (going through All reports).

This does not happen when logged in as an admin, but it does happen when logged in as a body user.

To Reproduce

Steps to reproduce the behavior:

  1. Log in as a body user (not an admin)
  2. Use the search functionality on the home page to go to the "around" view
  3. Note the states in the "Show" dropdown

Expected behavior

The same report filters are always shown no matter how body users get to the report lists (be it via the around view or the report view).

Desktop (please complete the following information):

  • OS: All systems
  • Browser All browsers
  • Version All versions

Additional context

When body users submit updates via the report view (All reports), and then click the link to see the report, the users end up in the around view. When this happens, users may not be able to filter the way they want to due to this issue.

@dracos
Copy link
Member

dracos commented May 17, 2023

On a reports page, we easily know the body involved so we can check the staff user belongs to the relevant body in order to show all states (this check is in the first line of templates/web/base/reports/_list-filter-status.html). On an around page, that information isn't currently looked up, so it only shows Open/Closed/Fixed. It looks like the Around.pm code does look up bodies (covering the centre point of the map, anyway) in order to work out what categories it can show (in case any staff only ones), so I imagine it should be able to somehow do a check there for what states to show as well.

@jonkri
Copy link
Contributor Author

jonkri commented Jan 19, 2024

There is a similar issue with the shortlist, which is limited to Open, Closed, Fixed and Private only.

@jonkri
Copy link
Contributor Author

jonkri commented Jan 19, 2024

Is there some way to enable all report states in the shortlist?

I'm thinking that since we know the body user ID, we should be able to infer the body ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants