spotlessApply the rest?

[tonygermano]

Is there any reason to not reformat the remaining main (not test) source files at this point just to get it out of the way? A good number of the files have already been done.

I think most of the old PRs and branches with large change sets that were created before spotless was required have been resolved now or likely contain files that have already been reformatted. I think it would make it easier to submit and review PRs going forward if they would otherwise require a separate spotless commit.

[p-bakker]

I'd say YES, go for it

[rbri]

• 1

[gbrail]

I could see doing that. I was hoping to avoid giant commits and unnecessary changes for future generations of maintainers, but we've already reformatted so many hairy 20-year-old source files that perhaps we should do the rest. But no, not the tests yet as I fear that would generate a truly gigantic number of changes.

…

On Fri, Sep 10, 2021 at 6:52 AM RBRi ***@***.***> wrote: - 1 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1024 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD7I274MOOGBLSYXQJQTZLUBIERHANCNFSM5DYDMGCQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[rbri]

did a quick check - we have still 90 files in the src folder that will change
and 28 in testsrc

[p-bakker]

Think we can conclude the answer is a resounding Yes.

@tonygermano Will you pick up this task?

[carlosame]

This could be done as part of #1092.

[p-bakker]

Wouldn't it be better to do it as a separate PR, as to not mix things?

[carlosame]

Wouldn't it be better to do it as a separate PR, as to not mix things?

Yes, but IMHO as long as the reformatting comes as a separate commit, the specific PR does not matter a lot. And the PR for #1092 would affect the entire codebase as well.

[p-bakker]

Unless the PR gets squashed during merge.

Also: getting the reformatted code into master as a separate PR is probably going to happen a lot faster than the Pr for #1092 (although I have no idea exactly what that one will entail)

[tuchida]

ref. #1159 Apply spotlessApply to all code.

[p-bakker]

Locking this discussion as this got done via #1159