Add configurable timeout to BigQuery query jobs #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it. Do you know if there's a default timeout in bigquery? 30 seconds seems perhaps a bit short to use as a default |
|
It looks like the default timeout is 6 hours? But @SorenSpicknall might know better than me, I don't use BigQuery and just got that from searching the documentation. |
austinweisgrau
requested changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up where somebody else's PR, #981, left off earlier this year. That PR closed because the original contributor deleted their fork after waiting unsuccessfully for merge.
This takes the spirit of those earlier proposed changes and adapts it to the current state of the BigQuery connector, hoping to resolve #910 once merged. I'm definitely open to a different approach if folks' thoughts on how to implement this default timeout have evolved since that last PR was active - @Jason94, I know you were part of that conversation at the time.