Fast and consistent matchNode

[Inviz]

Hello there.

Slick.match() may return following values:

• false - nothing is matched
• true - selector equals node or native matcher used (?)
• node - when the node was matched

Thing is that a returned node may be useful, but I does not return it all the time reliably.

My suggestion is to return either false or true all the time and allow to pass node as a third argument.

This is my latest take on the problem:

https://gist.github.com/927160

First of all, it doesnt use global search to do the matching of a complex selector.
Second, it figures out if the last reversed bit will return single or many elements (e.g. "~ div" and "+ div" will return array or a node respectively when reversed)
Third, it has a third argument that does the required check (e.g. you can do Slick.match(li, '> li', ul)). Basically it reverts the selector and checks if the needle is in the haystack.
Fourth, it consistently returns true or false if it's matched or not. Not the node.

It's fast and works with all selectors in my app (i use much of the complex stuff). Sorry for no tests.

[Inviz]

@markiz @subtleGradient @cpojer @fabiomcosta @arian

I'd be happy for some feedback This ultimate reverse-matcher is both faster and more powerful than what we have now.

[cpojer]

What about an actual pull request so we can run the specs with your changes?

[fabiomcosta]

yeah, make a pull request and let us use the specs we have today, to make
sure everything is ok.
The idea is awesome, if everything passes it will be pulled for sure :)
Thanks!

Fbio Miranda Costa
twitter: @fabioMiranda
github: fabiomcosta

On Wed, Apr 20, 2011 at 6:58 AM, cpojer <
[email protected]>wrote:

What about an actual pull request so we can run the specs with your
changes?

Reply to this email directly or view it on GitHub:
#39 (comment)

[Inviz]

#40

Pull request is there. Benchmarks revealed that the fastest way was the oldest one when nativeMatchSelector was available. Recursive (mine) is a little bit slower but it wins big time when there's no cheating nativeMatchSelector given.

[Inviz]

I couldnt figure out how to run the full test suite, it didnt work for me.

[arian]

git submodule update --init --recursive

Browse to /SlickSpec/Runner/