Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App doesn't sanitize file names from Modpacks #2925

Open
3 tasks done
Minenash opened this issue Nov 8, 2024 · 0 comments
Open
3 tasks done

App doesn't sanitize file names from Modpacks #2925

Minenash opened this issue Nov 8, 2024 · 0 comments
Labels
app Relates to Modrinth App bug Something isn't working

Comments

@Minenash
Copy link
Contributor

Minenash commented Nov 8, 2024

Please confirm the following.

  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date

What version of the Modrinth App are you using?

0.8.9

What operating systems are you seeing the problem on?

Windows

Describe the bug

Files in zips/mrpack can contain letters not allowed by Windows (" for example). Windows's file-manager (or 7zip, not sure) handles this by replacing the characters that aren't valid in windows with an underscore.

The app doesn't do this, it tries to copy the file but since the path is invalid, it fails and the instantiation is aborted

Steps to reproduce

  1. Try to install the modpack Garry's Mod v1.13.0
  2. See copy error

Expected behavior

No response

Additional context

No response

@Minenash Minenash added app Relates to Modrinth App bug Something isn't working labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Relates to Modrinth App bug Something isn't working
Development

No branches or pull requests

1 participant