Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow status flagged as completed when the conda command fails #18

Open
taxe10 opened this issue Mar 22, 2024 · 1 comment
Open

Flow status flagged as completed when the conda command fails #18

taxe10 opened this issue Mar 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@taxe10
Copy link
Member

taxe10 commented Mar 22, 2024

As discussed with @Wiebke. There are some instances where the conda flows do not log execution errors correctly. I think run_conda.sh may be missing something like:

if [ "$?" -ne 0 ]; then
    echo "Failed to run conda command"
    exit 1
fi

echo "Successfully run conda command"
exit 0

Additionally, the conda_flow.py would need:

from prefect.states import Failed
...
if process.returncode != 0:
        return Failed(message="Conda command failed")

@dylanmcreynolds

@taxe10 taxe10 self-assigned this Mar 22, 2024
@taxe10 taxe10 added the bug Something isn't working label Mar 22, 2024
@taxe10
Copy link
Member Author

taxe10 commented Mar 26, 2024

Fixed #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant