You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of version 6.0.3 today this is current implementation of BucketExistsAsync
I noticed that in the part
if an InternalClientException is caught, then the function will return true in these 2 cases :
ice.ServerResponse is null && ice.ServerResponse is not null
ice.ServerResponse is not null && HttpStatusCode.NotFound != ice.ServerResponse.StatusCode
The first case is a contradictory condition
maybe u meant to write second case only ? or maybe smt else (either way it seems to need some refactoring)
The second case is a bit confusing ? why would we consider the bucket exists if the StatusCode was different from NotFound ? Do all other InternalClientException.ServerResponse.StatusCode cases mean the bucket exist ?? shouldn't we let the exception be thrown in some cases ?
The text was updated successfully, but these errors were encountered:
It looks like this is the same issue with #1131 you filed before.
Although they are duplicates, I'll keep it open so that you can try all your scenarios to test the fix, PR #1141, for this issue and if you are satisfied, to close the issue.
As of version 6.0.3 today this is current implementation of BucketExistsAsync
I noticed that in the part
if an InternalClientException is caught, then the function will return true in these 2 cases :
The first case is a contradictory condition
maybe u meant to write second case only ? or maybe smt else (either way it seems to need some refactoring)
The second case is a bit confusing ? why would we consider the bucket exists if the StatusCode was different from NotFound ? Do all other InternalClientException.ServerResponse.StatusCode cases mean the bucket exist ?? shouldn't we let the exception be thrown in some cases ?
The text was updated successfully, but these errors were encountered: