Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpkg.com call in the front #3468

Open
p1r4t3-s4il0r opened this issue Nov 6, 2024 · 5 comments
Open

unpkg.com call in the front #3468

p1r4t3-s4il0r opened this issue Nov 6, 2024 · 5 comments
Assignees

Comments

@p1r4t3-s4il0r
Copy link

NOTE

Please subscribe to our paid subscription plans for 24x7 support from our Engineering team.

Trough a web browser, the login page of minio is making a request to https://unpkg.com/[email protected]/dist/benchmark/d-amd.json.

Expected Behavior

I want do deactivate this request.

Current Behavior

Request to https://unpkg.com/[email protected]/dist/benchmark/d-amd.json.

Steps to Reproduce (for bugs)

  1. Go to login page
  2. Open the inspector
  3. Go to network and reload the page
  4. You should see a request to unpkg.com

Context

I need to deactivate this request. Because I want to prevent unwanted call to internet.

Regression

No regression (as far as I know).

Your Environment

  • MinIO version used (minio --version): RELEASE.2024-07-16T23-46-41Z
  • Server setup and configuration: docker compose
  • Operating System and version (uname -a): Alma Linux 4.18
@ramondeklein
Copy link
Collaborator

ramondeklein commented Nov 6, 2024

Just confirmed that RELEASE.2024-10-29T16-01-48Z is making this request. Just checked the code and this is coming from the LoginWrapper in the MDS component (source). It looks like this is used to determine if a GPU is available to play the background video in the login-page.

@p1r4t3-s4il0r
Copy link
Author

Thanks for your answer.

Are you planning on implementing a environment variable to control this behavior ?

Thanks.

@harshavardhana
Copy link
Member

Are you planning on implementing a environment variable to control this behavior ?

Set

export MINIO_BROWSER_LOGIN_ANIMATION=off

@ramondeklein
Copy link
Collaborator

@harshavardhana This disables the login animation, but it still makes the call to unpkg.com.

@ramondeklein ramondeklein reopened this Nov 6, 2024
@ramondeklein
Copy link
Collaborator

See minio/mds#1091.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants