Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: PostgREST.postgrest version 12.2.3 #189441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New package: PostgREST.postgrest version 12.2.3 #189441

wants to merge 1 commit into from
+70 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Nov 7, 2024 •
edited by microsoft-github-policy-service bot
Loading

Notes

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@Dragon1573
New package: PostgREST.postgrest version 12.2.3
f6425e3 
- External dependencies required, add "InstallationNotes" for it.

Signed-off-by: Dragon1573 <[email protected]>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Nov 7, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\postgrest.exe returned exit code: -1073741515

Automated error analysis suggests -1073741515 may mean STATUS_DLL_NOT_FOUND - possibly due to a dependency on Microsoft.VCRedist.2015+.x64 (or .x86).

(Automated response - build 897.)

@develop7
Copy link

develop7 commented Nov 8, 2024 •
edited
Loading

@stephengillie yes, it depends on psql.dll (and its' dependencies). Installation notes seem to mention that

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 8, 2024
@stephengillie
Copy link
Collaborator

Hi @Dragon1573,

Is a dependency missing? The application refuses to run, instead giving this message on each launch.
image

Verify:
image

@stephengillie
Copy link
Collaborator

Hi @develop7,

Please understand that my previous response was the output of a scripted process which downloads the run logs, filters to include and exclude specific terms, then matches this against a list of error codes - before it posts this output as a comment into the PR. I'm dealing with capacity issues and just getting to this PR for the first time.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Nov 8, 2024
@Dragon1573
Copy link
Contributor Author

  1. libpq.dll can be downloaded and installed via package identifier PostgreSQL.psqlODBC.
  2. The "dependency" package will not add itself to $env:PATH.
  3. postgrest.exe can't load libpq.dll and failed to launch.

@stephengillie , I don't have good solution for resolving this problem. 😞

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 8, 2024
Dragon1573
Dragon1573 commented Nov 8, 2024
View reviewed changes
Copy link
Contributor Author

@Dragon1573 Dragon1573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem is already mentioned before.

manifests/p/PostgREST/postgrest/12.2.3/PostgREST.postgrest.installer.yaml
Comment on lines +15 to +17
Dependencies:
ExternalDependencies:
- libpq.dll
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libpq.dll is mentioned here as an external dependency.

manifests/p/PostgREST/postgrest/12.2.3/PostgREST.postgrest.locale.en-US.yaml
Comment on lines +33 to +36
InstallationNotes: |-
"libpq.dll" is required by this package. It can be found in any version of PostgreSQL ODBC drivers.
Available via "PostgreSQL.psqlODBC" in WinGet. You should manually add it's "bin/" directory (
"$env:PROGRAMFILES/psqlODBC/<version>/bin" by default) into "$env:PATH" environment variable.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I note here and asking users to resolve "libpq.dll not found" error on their own.

@stephengillie
Copy link
Collaborator

So the package has a dependency, and a workaround is needed to address a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package Validation-Executable-Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: PostgREST
5 participants
@Dragon1573 @wingetbot @stephengillie @develop7 @ItzLevvie