Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Request]: PostgREST #189017

Open
1 task done
develop7 opened this issue Nov 6, 2024 · 9 comments · May be fixed by #189441
Open
1 task done

[Package Request]: PostgREST #189017

develop7 opened this issue Nov 6, 2024 · 9 comments · May be fixed by #189441
Labels
In-PR Package-Request This is a request for a package (new or updated version) Validation-Executable-Error

Comments

@develop7
Copy link

develop7 commented Nov 6, 2024

How can we help?

I would like someone else to build the manifest.

Please read and ensure the following

  • The installer meets the above requirements

Please provide the following information

Download Page Url: https://github.com/PostgREST/postgrest/releases/latest
Publisher: PostgREST.org
Package Name: PostgREST
Description: PostgREST is a standalone web server that turns your PostgreSQL database directly into a RESTful API. The structural constraints and permissions in the database determine the API endpoints and operations.
Package Version: 12.2.3
Installer Url: https://github.com/PostgREST/postgrest/releases/download/v12.2.3/postgrest-v12.2.3-windows-x64.zip

@develop7 develop7 added Help-Wanted This is a good candidate work item from the community. Package-Request This is a request for a package (new or updated version) labels Nov 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Nov 6, 2024
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Nov 6, 2024
@stephengillie
Copy link
Collaborator

When many dependencies could meet the need, we've been adding a note in the PR and then omitting a dependency. Should the same be done here?

@develop7
Copy link
Author

develop7 commented Nov 6, 2024 via email

@Dragon1573
Copy link
Contributor

Test with [email protected] and [email protected]. Both of them can't provide required LIBPQ.dll for postgrest.exe. 😞

Image

@develop7
Copy link
Author

develop7 commented Nov 7, 2024

@Dragon1573
Copy link
Contributor

Scoop is "script-based" package manager. It can perform "black magic" with pre/post-install scripts. WinGet and Chocolatey can't perform this behavior.

Although adding PostgreSQL.psqlodbc as dependency, it still not work. 😞

Image

@develop7
Copy link
Author

develop7 commented Nov 7, 2024

it could indeed, but it doesn't — it just extracts files from .msi installer and, I assume, puts them aside to postgrest.exe. Is there some well-known directory in Windows to put DLLs in, so they will be available for random executables to import when required?

@Dragon1573
Copy link
Contributor

There contains a special property as follows:

// https://github.com/ScoopInstaller/Main/blob/d8813f59adf972a9f39c50f99fa666f7bdeacf0d/bucket/psqlodbc.json#L17
{
    "env_add_path": "bin"
}

This configuration instruct Scoop adding the bin/ directory into $env:PATH variable during "post-install" scenario.

According to Komac, manifest of PostgreSQL.psqlODBC uses Burn EXE and WiX MSI installer type. All "system modifications" are done by the installer file itself. WinGet will do nothing with the installer. The bin/ directory of PostgreSQL.psqlODBC should be added to $env:PATH environment variable by installer file itself.

Image

@develop7
Copy link
Author

develop7 commented Nov 7, 2024

I see. Thank you for the clarification.

@Dragon1573
Copy link
Contributor

Tip

If I manually add $env:PROGRAMFILES\psqlODBC\1700\bin to $env:PATH, then postgrest.exe can be launched as expected.

I didn't install and run PostgreSQL server in the Windows Sandbox instance, so it can't connect to localhost:5432. It's expected.

Image

@Dragon1573 Dragon1573 linked a pull request Nov 7, 2024 that will close this issue
7 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR and removed Help-Wanted This is a good candidate work item from the community. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Package-Request This is a request for a package (new or updated version) Validation-Executable-Error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants