Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Request]: 8x8 Virutal Office & 8x8 Work #135119

Closed
jahvari opened this issue Jan 17, 2024 · 6 comments · Fixed by #136146
Closed

[Update Request]: 8x8 Virutal Office & 8x8 Work #135119

jahvari opened this issue Jan 17, 2024 · 6 comments · Fixed by #136146
Labels
In-PR Package-Update This package needs to be updated
Milestone

Comments

@jahvari
Copy link
Contributor

jahvari commented Jan 17, 2024

What type of update are you requesting?

A change to the Package Identifier

Current Package Identifier

8x8.VirtualOfficeDesktop

Package Version

PACKAGE NAME

Please describe the changes you would like to see

There are two different packages for the same piece of software. 8x8 Work is the new name for the desktop app, it used to be called virtual office. Is it possible to delete the 8x8 work package and just rename the other package to 8x8 Work? I am not sure how the @PckgrBot works and updates the package automatically but it is doing a good job when a new software version is released.

Screenshot 2024-01-16 at 21-15-39 winget-pkgs_manifests_8 at master · microsoft_winget-pkgs

@jahvari jahvari added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated labels Jan 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 17, 2024
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 17, 2024
@PckgrBot
Copy link
Contributor

Hello, so to confirm you want the ID to become 8X8.Work? And then cleanup the rest?

@jahvari
Copy link
Contributor Author

jahvari commented Jan 21, 2024

@PckgrBot yes this to become 8x8.work and then the other package can be removed completely.

@BiosPlus
Copy link
Contributor

There seems to be both 8x8Inc and 8x8 as parent dirs too.
I'm happy to take this on and rework/consolidate this all into 8x8.Work.

  1. Create a PR for version 7.4.3 under ID 8x8.Work, sourcing from 8x8.VirtualOfficeDesktop\7.4.3.5.
  2. Once that's been accepted, submit update PRs for all of the additional 24 versions.
  3. Submit removal PRs for packages under 8x8Inc.Work and 8x8.VirtualOfficeDesktop.
    So that way there are no interruptions to people pulling the existing packages.

@jahvari
Copy link
Contributor Author

jahvari commented Jan 24, 2024

@BiosPlus I appreciate the help!

@BiosPlus
Copy link
Contributor

Noice, that got accepted, I'll do the rest now :)

This was referenced Jan 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR and removed Help-Wanted This is a good candidate work item from the community. labels Jan 25, 2024
@denelon denelon added this to the 1.7 Packages milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Package-Update This package needs to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants