Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THROW_WIN32_IF_MSG / THROW_WIN32_IF_MSG doesn't exist. #377

Open
JeffMill opened this issue Oct 2, 2023 · 1 comment
Open

THROW_WIN32_IF_MSG / THROW_WIN32_IF_MSG doesn't exist. #377

JeffMill opened this issue Oct 2, 2023 · 1 comment
Labels
feature-request New feature or request

Comments

@JeffMill
Copy link

JeffMill commented Oct 2, 2023

THROW_WIN32_MSG() exists, but not THROW_WIN32_IF_MSG to avoid someone needing to write:

THROW_HR_IF_MSG(HRESULT_FROM_WIN32(ERROR_NOT_FOUND), (count !=1), "something")
@dunhor dunhor added the feature-request New feature or request label Oct 2, 2023
@dmachaj
Copy link
Contributor

dmachaj commented Oct 2, 2023

Seems reasonable. A lot of scenarios are covered by things like THROW_IF_WIN32_BOOL_FALSE to cover the win32 APIs that return 0 on failure and nonzero on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JeffMill @dunhor @dmachaj