Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTML] Ctrl+clicking an URL in an a href attribute fails due to an incorrectly URL-encoded % character #233851

Open
anthonyvdotbe opened this issue Nov 14, 2024 · 4 comments
Assignees

Comments

@anthonyvdotbe
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.95.2 (user setup) e865366
  • OS Version: Windows_NT x64 10.0.26100

Steps to Reproduce:

  1. create an HTML file with the following content
<a href="https://domain.foo/bar.do%3Fsys_id%3Df92fac57339d9a10b0274a028d5c7b74%26sysparm_stack%3D%26sysparm_view%3D">
</a>

https://domain.foo/bar.do%3Fsys_id%3Df92fac57339d9a10b0274a028d5c7b74%26sysparm_stack%3D%26sysparm_view%3D
  1. ctrl+click both links

Expected:
both links work

Actual:
the link in the href attribute does not work because the first % is incorrectly percent-encoded (as %25)

@erharsh237
Copy link

Hi, I was checking the issue, can you please elaborate more on this issue?
when i am doing ctrl+click both links are working.

@anthonyvdotbe
Copy link
Author

@erharsh237
Copy link

Hi, i again checked the issue, the links are working in the firefox browser as well.
Image

@anthonyvdotbe
Copy link
Author

I've changed the URLs: obviously domain.foo doesn't exist, so equally obviously you'll see the same error page for both links. If you'd be using the actual domains, you'd notice that the %25 in the first link causes issues. Please consider removing your comments, so I can remove mine as well and the VS Code developers don't have to waste time reading this nonsensical discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants