Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to remove a breakpoint still removes the breakpoint marker #233839

Open
jlonnberg opened this issue Nov 14, 2024 · 0 comments
Open

Failing to remove a breakpoint still removes the breakpoint marker #233839

jlonnberg opened this issue Nov 14, 2024 · 0 comments
Assignees

Comments

@jlonnberg
Copy link

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.95.2
  • OS Version: Windows

The problem occurs when trying to remove a breakpoint but failing to do so still removes the breakpoint marker from the UI.

Our debugger extension for embedded can fail to remove a breakpoint from the embedded system due to numerous reason. However, regardless how we structure the SetBreakpointResponse, the breakpoint is removed from the UI but is still active in the debugger. The user has no way of removing the breakpoint but it will still hit.

Reading the DAP doc for setBreakPointsRequest suggests that there needs to be a 1:1 mapping between the list of suggested breakpoints and the actual ones. However, during the remove-step, the list of suggested breakpoint has already excluded the one to be removed to even though we list the removed breakpoint as still active, VS Code does not accept that we failed to remove breakpoint and removes the bp marker.

Steps to Reproduce:

  1. Create a breakpoint
  2. Remove the breakpoint but fail in doing so
  3. The breakpoint is removed from the UI but still left in the debugger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants