Improve parsing of responses from the AI #18201
Open
+46
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I initially wanted to directly use the |
PankajBhojwani
commented
Nov 15, 2024
Comment on lines
+242
to
+247
| if (!currentRun.empty()) | ||
| { | ||
| const auto chatMsg = winrt::make<ChatMessage>(winrt::to_hstring(currentRun), false, false); | ||
| messageParts.push_back(chatMsg); | ||
| currentRun.clear(); | ||
| } |
There was a problem hiding this comment.
Don't like that this is the exact same as lines 227-231 but making a helper function for 3 lines of code seems silly...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Instead of manually parsing out code blocks from the response we receive, use the
cmarklibrary.Validation Steps Performed
Responses are parsed as expected.
PR Checklist