Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default linkage flag - how to transition from DXC's -default-linkage to Clang #242

Closed
hekota opened this issue May 20, 2024 · 2 comments
Closed

Default linkage flag - how to transition from DXC's -default-linkage to Clang #242

hekota opened this issue May 20, 2024 · 2 comments
Labels
needs-triage

Comments

@hekota
Copy link
Member

hekota commented May 20, 2024 •
edited by damyanp
Loading

This issue has been moved to llvm/wg-hlsl#58

In DXC the -default-linkage compiler flag changes the default linkage of all functions in a translation unit. It accepts values external and internal (which is the default). This issue is to track how we should transition from the DXC flag to Clang.

Clang's has -fvisibility flag which determines the visibility of functions, but no flag that affects linkage.
@hekota hekota changed the title Default linkage flag - figure out transition from DXC's -default-linkage to Clang's -fvisibility Default linkage flag - how to transition from DXC's -default-linkage to Clang's -fvisibility May 20, 2024
@hekota hekota changed the title Default linkage flag - how to transition from DXC's -default-linkage to Clang's -fvisibility Default linkage flag - how to transition from DXC's -default-linkage to Clang May 28, 2024
@hekota hekota mentioned this issue Aug 1, 2024
Merged
@damyanp
Copy link
Member

damyanp commented Aug 13, 2024

@damyanp - move this to wg-hlsl

@damyanp
Copy link
Member

damyanp commented Sep 4, 2024

Moved to llvm/wg-hlsl#58

@damyanp damyanp closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
@github-project-automation github-project-automation bot moved this to Triaged in HLSL Triage Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage
Projects
HLSL Triage
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@damyanp @llvm-beanz @hekota