Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\hosting is missed in Code Structure #773

Closed
xiaofeng-zheng opened this issue Nov 5, 2024 · 2 comments · Fixed by #802
Closed

\hosting is missed in Code Structure #773

xiaofeng-zheng opened this issue Nov 5, 2024 · 2 comments · Fixed by #802
Assignees
@TalZaccai

Comments

@xiaofeng-zheng
Copy link

Feature request type

enhancement

Is your feature request related to a problem? Please describe

website/docs/dev/code-structure.md is out of date. I guess #614 imported this folder. Could the author @pradeepyadavmsft or someone else add some description in the documentation?

Describe the solution you'd like

Explain this folder.

Describe alternatives you've considered

No response

Additional context

No response
@xiaofeng-zheng
Copy link
Author

It seems this folder implements a Windows service wrapper. But it doesn't register extensions like here. It would be helpful if someone could explain it as well

@badrishc
Copy link
Contributor

badrishc commented Nov 7, 2024

Registration of extensions is just for sample purposes to show how that works. It is not necessary in both places.

@TalZaccai TalZaccai self-assigned this Nov 12, 2024
@TalZaccai TalZaccai linked a pull request Nov 15, 2024 that will close this issue
Updating code structure doc #802
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TalZaccai TalZaccai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating code structure doc microsoft/garnet
3 participants
@badrishc @TalZaccai @xiaofeng-zheng