Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix Socket Listen Support #682

Open
batonac opened this issue Sep 20, 2024 · 1 comment
Open

Unix Socket Listen Support #682

batonac opened this issue Sep 20, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@batonac
Copy link

batonac commented Sep 20, 2024

Feature request type

enhancement

Is your feature request related to a problem? Please describe

Some of us prefer to avoid the overhead of TCP/IP when connecting services on the same machine.

Describe the solution you'd like

Two more flags: unixsocket and unixsocketperm

GarnetServer --unixsocket /tmp/redis.sock --unixsocketperm 770

Describe alternatives you've considered

Use one of the many alternatives that support unix sockets 😄

Additional context

The flags above are identical to Redis FYI.

@badrishc badrishc added enhancement New feature or request help wanted Extra attention is needed labels Sep 21, 2024
@yrajas yrajas self-assigned this Sep 24, 2024
@xiaofeng-zheng
Copy link

Hi team, are you still considering this enhancement? I'd like to confirm it before I do any dev works. I'm seeing the current implementation assumes everywhere that there's only one TCP server listening for the connections so I'm not sure if it's a big change to support Unix socket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants