Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resample function call in dnsmos_local.py #182

Open
qianjr2002 opened this issue Apr 16, 2024 · 1 comment
Open

Update resample function call in dnsmos_local.py #182

qianjr2002 opened this issue Apr 16, 2024 · 1 comment

Comments

@qianjr2002
Copy link

qianjr2002 commented Apr 16, 2024

I found an issue in the code dnsmos_local.py where the librosa.resample() function is called without specifying the required keyword-only arguments orig_sr and target_sr.

The current code:

audio = librosa.resample(aud, input_fs, fs)

Should be updated to:

audio = librosa.resample(aud, orig_sr=input_fs, target_sr=fs)

This change ensures that the original sampling rate (input_fs) and the target sampling rate (fs) are correctly specified when resampling the audio data. This modification resolves an error where the resample() function is called with missing required keyword-only arguments.

Please consider updating the code accordingly. Thank you!

@Rodolfo-S
Copy link

I just posted an issue about this. I probably just have just added onto this one. The current master specifies a librosa version

librosa==0.8.1

so the arguments shouldn't cause a positional argument error. I do agree that it would be better if it were changed though. They could use newer version of librosa in future revisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants