Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add the ability to skip ID3 tags/ID3 data #20

Closed
jcjordyn130 opened this issue May 24, 2018 · 6 comments · Fixed by #21
Closed

[Feature Request] Add the ability to skip ID3 tags/ID3 data #20

jcjordyn130 opened this issue May 24, 2018 · 6 comments · Fixed by #21
Assignees
Milestone

Comments

@jcjordyn130
Copy link

The library expects a flac signature but doesn't skip over ID3 data to try to find it.

@karlek karlek self-assigned this May 24, 2018
@mewmew mewmew added this to the v1.0.6 milestone May 24, 2018
@mewmew
Copy link
Member

mewmew commented May 24, 2018

@karlek I'll leave this one to you :)

@jcjordyn130
Copy link
Author

That was quick 👍

@mewmew
Copy link
Member

mewmew commented May 24, 2018

@jcjordyn130 Do you have any test case for this that we could add? Preferable small in file size and if possible in the public domain (so we don't run into license issues).

@jcjordyn130
Copy link
Author

Here's the audio file that made me open this PR, minus the audio data and with the tags set to generic values: https://transfer.sh/S3Aq7/id3.flac

@mewmew
Copy link
Member

mewmew commented May 25, 2018

@jcjordyn130 Thanks for reporting the issue and for the tight feedback loop on resolving it :)

If you are working on audio development or like playing with these kinds of libraries, we'd be very interested for you to join our discussion in #19.

Cheers!
Henry and Robin

@jcjordyn130
Copy link
Author

jcjordyn130 commented May 25, 2018

You're very welcome, and I think I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants