-
Please sign the UCX contributors agreement.
-
Please follow the code style and logging style.
-
Make sure automatic tests pass.
-
Request a review by mentioning the relevant reviewer.
-
PR which is reviewed and currently waiting for a fix and/or response, will be marked with "Waiting for Author Response" by the reviewer,
-
If you need to fix your PR, there are 2 options: amend (replace) your commit, or add new commit with fixes.
- Before anyone has posted comments on the PR, it's allowed to amend.
Example: Fixing bugs found in automatic tests. - If some comments have been posted, the fixes should be in a new commit.
Reason: Replacing the commit discards the comments.
- After getting 👍 from one or more of UCX maintainers the PR can be merged.
More details here.