Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch package manager to pnpm #1660

Closed
flevi29 opened this issue May 23, 2024 · 4 comments
Closed

Switch package manager to pnpm #1660

flevi29 opened this issue May 23, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@flevi29
Copy link
Collaborator

flevi29 commented May 23, 2024

A lot of high profile repositories these days use pnpm.

The list goes on.

We could just upgrade yarn, but I am more familiar with pnpm and I generally see that pnpm is more popular these days, although their latest version is not on npmjs, so it's not really trackable. Speed seems to be on par, with pnpm having a slight edge perhaps (https://pnpm.io/benchmarks) https://p.datadoghq.eu.

Lockfile can be transformed.

We can also use the latest and greatest corepack features of Node.js.

@flevi29 flevi29 added the enhancement New feature or request label May 23, 2024
@curquiza
Copy link
Member

Hello, I saw discussion here, but I answer in this issue for an easier traceability with community: I'm not sure this change is worth it. We would like to keep what is working and yarn is not deprecated and still widely used. We want to avoid pain and work in order to focus on the most critical things. I'm afraid of the new pains this huge change could bring.

However I agree with you @flevi29, updating yarn could be a good move

Would love to have the opinion of the community of this

@flevi29
Copy link
Collaborator Author

flevi29 commented May 29, 2024

I'm not so sure about this huge pain and work. I detailed in the PR in my last comment that this will not be the case because of how corepack works, that's literally the whole point of corepack. EDIT: Sorry if I'm being rude.

Anyhow, the way I see it, to upgrade you'll still need to change actions/setup-node@v4 to enable corepack instead of installing yarn globally.
Read on Yarn's page more: https://yarnpkg.com/getting-started/install

@flevi29
Copy link
Collaborator Author

flevi29 commented May 29, 2024

Alright fair enough, switching to pnpm might be a little much, I'll open another issue for updating yarn.

@flevi29 flevi29 closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
@flevi29
Copy link
Collaborator Author

flevi29 commented May 29, 2024

Closed in favour of #1664.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants