Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #33

Open
elfring opened this issue Jul 25, 2018 · 2 comments
Open

reserved identifier violation #33

elfring opened this issue Jul 25, 2018 · 2 comments
Labels
TODO TODO

Comments

@elfring
Copy link

elfring commented Jul 25, 2018

I would like to point out that identifiers like “_CODECS_H_” and “_MEDIA_H_” do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@murillo128
Copy link
Member

Yes, I recently discovered that defines starting with an underscore are reserved, would you be willing to provide a CR?

@murillo128 murillo128 added the TODO TODO label Jul 27, 2018
@elfring
Copy link
Author

elfring commented Jul 27, 2018

Would any other software developers like to improve affected places quicker (than me)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TODO TODO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @murillo128