Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a banner filter value on the preview page exists more than once we will get a react key error #81

Open
mm-paulie opened this issue Oct 10, 2023 · 0 comments
Open

If a banner filter value on the preview page exists more than once we will get a react key error #81

mm-paulie opened this issue Oct 10, 2023 · 0 comments
Assignees
@mm-paulie
Labels
bug Something isn't working

Comments

@mm-paulie
Copy link
Collaborator

mm-paulie commented Oct 10, 2023 •
edited
Loading

Resolve the bug that, whenever there is banner filter value on the preview page that exist more than two times, that react throws a key error. For example, two names that will give an error since de is not in the same filter "row":
src_banners_120x600__sale_nointro_endofseasonsale_de and
src_banners_120x600__sale_de

example (filter on "de")
https://richmedia-previews-s3bucket-tu6a9uv81tss.s3.amazonaws.com/1f08c1d9-b4f1-4a47-831b-409cf070b151/nike-commerce-creative-templates/preview/test_git_new_dev_preview/index.html
@mm-paulie mm-paulie added the bug Something isn't working label Oct 10, 2023
@mm-paulie mm-paulie self-assigned this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mm-paulie mm-paulie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mm-paulie