You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the user's second message gets redacted to hide the field values (they might contain tokens or other secrets).
When a user logs in direct (checkLoginCommandDirectParams), e.g.:
> login token xyz... abc...
the message is left unredacted, with the values in plaintext.
Any reason for this differing behavior with respect to redactions? Can we assume that if the user provided extra ce.Args, they're probably attempting to provide login secrets, and we should issue a redaction for them? Or do some login flows allow only non-secret extra args that we want to keep around and not redact? Thoughts?
The text was updated successfully, but these errors were encountered:
Perhaps the intent of the Redact is more to keep the bot chat tidy, getting rid of long curl... text garbage, more than obfuscating secrets? If that's the case, feel free to close this issue.
When a user logs in with two steps, e.g.
the user's second message gets redacted to hide the field values (they might contain tokens or other secrets).
When a user logs in direct (
checkLoginCommandDirectParams
), e.g.:the message is left unredacted, with the values in plaintext.
Any reason for this differing behavior with respect to redactions? Can we assume that if the user provided extra
ce.Args
, they're probably attempting to provide login secrets, and we should issue a redaction for them? Or do some login flows allow only non-secret extra args that we want to keep around and not redact? Thoughts?The text was updated successfully, but these errors were encountered: