Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search function not working as expected #539

Open
RolfLund opened this issue Jul 14, 2022 · 1 comment
Open

Search function not working as expected #539

RolfLund opened this issue Jul 14, 2022 · 1 comment

Comments

@RolfLund
Copy link

RolfLund commented Jul 14, 2022

Hey there.

Thank you for an awesome theme - I have used the learn-theme a lot and it is great!

I have had some trouble getting the search function to work as intended. By adding:

[outputs]
home = [ "HTML", "RSS", "JSON"]

And it kinda does the job. It searches text in menus that are already open but if the menu is closed, it is unable to search within. Perhaps this is intended functionality, but it would be massively helpful if it could search collapsed menus as well.

I am using Hugo v.0.90.1 and have tested with Brave, Chrome and Firefox.

@McShelby
Copy link

It's bit unclear from the description what you want to achieve.

I assume: If you open the homepage at learn.netlify.app and search for "Requirements" you want to open the "Basics" menu and mark the "Requirements" menu point?

That's currently not possible with this theme and I doubt it will got implemented as this theme is dead. Technically this would require collapsible menus which also isn't a feature of this theme althought it was long requested (#511, #414, #88)

I've implemented a feature into the Relearn fork that opens expand-shortcodes if a search term is found in there.

The same mechanism may also be used to also open collapsed menus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants