Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strikethrough text? #33

Open
pratul opened this issue Mar 1, 2023 · 5 comments
Open

Strikethrough text? #33

pratul opened this issue Mar 1, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@pratul
Copy link
Contributor

pratul commented Mar 1, 2023

I tried the usual markdown syntax of surrounding text with ~~ but it doesn't seem to work. Does mataroa not support strikethrough formatted text?

@sirodoht
Copy link
Member

sirodoht commented Mar 1, 2023

Hey @pratul,

The markdown library we use (Python-Markdown) supports John Gruber’s markdown spec, which does not define strikethrough text.

We also use some extensions (fenced_code, tables, footnotes, toc) that are outside the spec but these are undocumented (on mataroa) and they might change.

I’ve found an extension for strikethrough text (from pymdownx / source) but I'm thinking to change the markdown library altogether to something else. Either mistletoe or mistune.

No specific timeline for this, though :)

@sirodoht sirodoht added the enhancement New feature or request label Mar 1, 2023
@ratsclub
Copy link
Member

ratsclub commented Jul 25, 2024

I'm interested into using mistune as the markdown library. I really like its Directive approach! Although we would need to re-implement the syntax highlight theme.

@sirodoht Are you still interested on this?

@sirodoht
Copy link
Member

Sure, yes! Feel free to work on it :)

@ratsclub
Copy link
Member

Okay, from my investigation mistletoe would require use to write a bunch of extensions... I don't think this is productive given that we already have most of them here.

On the other side, mistune would only need a new footnotes plugin as it doesn't add a <hr/> tag. What do you think? Should we add the strikethrough extension to our current markdown library or migrate to mistune and write the footnotes (basically copying and pasting the official one, but adding a <hr/> tag)?

@sirodoht
Copy link
Member

I like mistune more but haven't done a deep look into it, so cannot say much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants