Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Do price rounding better in sai_maker_otc.py #2

Open
ghost opened this issue Dec 7, 2017 · 2 comments · May be fixed by #133
Open

Do price rounding better in sai_maker_otc.py #2

ghost opened this issue Dec 7, 2017 · 2 comments · May be fixed by #133

Comments

@ghost
Copy link

ghost commented Dec 7, 2017

Due to precision issues, the price rounding mechanism currently used in sai_maker_otc.py doesn't guarantee that a price will always be displayed with the required number of decimal places (e.g. in the Oasis frontend). It may be preferable to round the quantities as well (but to a different number of digits) in order to achieve a consistent number of decimal places.

Authored by @livnev, moved from: makerdao/pymaker#35.

@adamjsawicki
Copy link

@reverendus Can this be closed? Doesn't look like this file exists in either repo.

@ghost
Copy link
Author

ghost commented Jan 22, 2020

@swixx I think this was about this flag https://github.com/makerdao/market-maker-keeper/blob/master/market_maker_keeper/oasis_market_maker_keeper.py#L111 which doesn't seem to be used for anything anymore. So I would say the issue can be closed as it's about a non-existent feature. Having said that it would be nice to remove the flag as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant