feat: add _CLIENT_LINEAR_MOVE macro #39
Open
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteyou
changed the title
pedrolamas
reviewed
Nov 16, 2024
Co-authored-by: Pedro Lamas <[email protected]>
|
@pedrolamas thx for the hint and your suggestion sound future proof and has no negative impact right now. I commit it. |
pedrolamas
reviewed
Nov 16, 2024
Comment on lines
+306
to
+311
| {% if 'X' in params or 'Y' in params or 'Z' in params %} | ||
| G9{ 0 if ABSOLUTE else 1 } | ||
| {% endif %} | ||
| {% if 'E' in params %} | ||
| M8{ 2 if ABSOLUTE_E else 3 } | ||
| {% endif %} |
There was a problem hiding this comment.
This is just checking if the parameter exists or not, not if it is empty (we can do _CLIENT_LINEAR_MOVE X= and Klipper will be just fine with that, so this is not correct)
So we need to check for param exists AND ensure that the value is NOT empty.
I took it a step further and just checked for the movement parts we are sending.
Suggested change
| {% if 'X' in params or 'Y' in params or 'Z' in params %} | |
| G9{ 0 if ABSOLUTE else 1 } | |
| {% endif %} | |
| {% if 'E' in params %} | |
| M8{ 2 if ABSOLUTE_E else 3 } | |
| {% endif %} | |
| {% if x_move or y_move or z_move %} | |
| G9{ 0 if ABSOLUTE else 1 } | |
| {% endif %} | |
| {% if e_move %} | |
| M8{ 2 if ABSOLUTE_E else 3 } | |
| {% endif %} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the macro _CLIENT_LINEAR_MOVE. This will make the console less noisy for UI movements.
This PR fixes #38