Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks! #22

Open
conor-f opened this issue Jan 28, 2022 · 1 comment
Open

Thanks! #22

conor-f opened this issue Jan 28, 2022 · 1 comment

Comments

@conor-f
Copy link
Contributor

conor-f commented Jan 28, 2022

Thank you for creating this @macintoshpie !

I submitted a few tiny PRs to update links, fix some small syntax issues, and other misc bits. Feel free to just close any PR that you don't feel fits.

Also, have you considered adding an example Github Actions workflow to this repo and using that to build + deploy to Netlify? It could be added as an example on the UI side of things so readers could see what a successful workflow looks like, a broken workflow, how jobs can be re-ran, etc etc

@macintoshpie
Copy link
Owner

Yo! Thanks for the help @conor-f ! I've been considering adding a workflow to the repo -- mostly to syntax check the YAML files, but it would be dope if all of the examples actually ran, I will chew on that.
I've been meaning to build in netlify as well (instead of checking in the public directory) -- going to look into that as well soon, but right now it uses a docker container which I don't think Netlify supports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants