You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was trying to implement CI to ensure the component compiles for the various versions of ESP-IDF.
The problem is that the project is not set up in a way that allows for this:
ESP-IDF components should be in a subfolder (commonly main/, but it could also be M5GFX/). Without this, any attempt to compile the component with idf.py build leads to this error:
Called idf_component_register from a non-component directory.
To allow for idf.py build to work independently in this project, these steps are required:
Add a subfolder for this component (main/ or M5GFX/), move relevant files into this folder and add a CMakeLists.txt
Add include($ENV{IDF_PATH}/tools/cmake/project.cmake) to the root CMakeLists.txt
Considering that moving source files has a big impact on your currently unmerged branches, I figured I'd open this issue to discuss the proposed changes.
The text was updated successfully, but these errors were encountered:
Hello, @KenVanHoeylandt
Sorry, it's my lack of understanding and I don't quite understand what you're asking.
Are you saying you want the main source code of the library to be in main instead of src?
Almost: I suggest to move the src folder into a subfolder (e.g. main or M5GFX).
Having src in its own folder allows us to create an ESP-IDF "module" (~ library/subproject).
I could make the CMakeList.txt files that would go along with it.
Once you have this module, you can compile it standalone, and thus we can avoid releases with compile errors as we can automate building.
I was trying to implement CI to ensure the component compiles for the various versions of ESP-IDF.
The problem is that the project is not set up in a way that allows for this:
ESP-IDF components should be in a subfolder (commonly
main/
, but it could also beM5GFX/
). Without this, any attempt to compile the component withidf.py build
leads to this error:Reference build: https://github.com/KenVanHoeylandt/M5GFX/actions/runs/8222729252/job/22484559726
.github/workflows/build.yml example:
To allow for
idf.py build
to work independently in this project, these steps are required:main/
orM5GFX/
), move relevant files into this folder and add aCMakeLists.txt
include($ENV{IDF_PATH}/tools/cmake/project.cmake)
to the rootCMakeLists.txt
Considering that moving source files has a big impact on your currently unmerged branches, I figured I'd open this issue to discuss the proposed changes.
The text was updated successfully, but these errors were encountered: