-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reporting of redirects and excluded links #1312
Comments
All good suggestions. Changing the behavior of -v and -vv is a breaking change, but it should be fine as we haven't released 1.0 yet. example.com is excluded by default as it's usually used as a placeholder. The gobyexample.com exclusion is a bug. For now, you can explicitly include it ( |
Thanks. FYI, I've tried a few variations of |
FYI, I fixed that issue in #1316. With the next release, it should just work as expected. |
The release with the fix is out. So if you update to lychee 0.14.0, the false-positive example domains should be gone. |
That leaves us with the following action items:
|
By "Only show 200 OK links in -vv output.", do you mean to not include 200 OK links in the That would be great for tracking down the redirects without all the noise of good links. |
Exactly. |
Hi Matthias. I'm running lychee on a book with 574 total links reported, which is making it a little difficult to know which links I need to correct. The book is written with AsciiDoctor, so I first generated an HTML file. I don't mind that *.adoc isn't supported (#291) directly by lychee.
Redirects
Running lychee nightly (or rather, compile from source), the main issue I'm seeing is that there are a number of redirects, but it's difficult to tell which redirect belongs to which link.
The redirect to
https://www.red-gate.com
... is from thehttps://www.simple-talk.com
link at the bottom of the screenshot shown, but they aren't tied together. I assume this is related to concurrency and the redirect being a debug log (#1117) rather than designed into the user experience.Ideally I'd like a report of which links required a redirect along with the final URL they redirected to. That way I could easily search for the original links and update them. (the intermediate redirects being a debug log is fine, as that doesn't concern me unless troubleshooting)
Excluded
A related concern is the "6 Excluded" when looking at a list this large. If I scroll through the verbose version I can track them down, but there are hundreds of
✔ [200]
lines that I want to ignore, even with a single-v
. Even piping togrep
doesn't help.Most of the excluded in my example are email addresses, which is fine (2 repeated a few times). But one excluded link is:
From the HTML
<a href="https://gobyexample.com" class="bare">gobyexample.com</a>
. I'm not entirely sure why. So that's the sort of thing I'd like listed out.Suggestion
I think that the good links should only be shown with
-vv
and the corrections should be clearly shown with a single-v
or even without.Also may want to double check if there's an example.com default exclusion that's a little too aggressive.
The text was updated successfully, but these errors were encountered: