Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show / hide behaviour when using "hide only on overlapping window" option #1644

Open
maoamid opened this issue Aug 9, 2021 · 13 comments · May be fixed by #1689
Open

show / hide behaviour when using "hide only on overlapping window" option #1644

maoamid opened this issue Aug 9, 2021 · 13 comments · May be fixed by #1689

Comments

@maoamid
Copy link

maoamid commented Aug 9, 2021

When "Show desktop" shortcut provided by Lxqt is used, the panel remain hidden if this was the latest state

Expected Behavior

Allways show the panel when all windows are minimized using keyboard shortcut provided by WM or DE

Steps to Reproduce (for bugs)
  1. maximize any active window on the screen => the panel is hiding as it should
  2. clear screen using Super + D (in my case) => the desktop is clean but the panel remain hidden
System Information

Void Linux (kernel 5.13.xx)
Lxqt 0.17 + Openbox

@tsujan
Copy link
Member

tsujan commented Aug 17, 2021

I couldn't find a NET::State that shows a window is invisible because the desktop is shown (NET::Hidden isn't set in this case, at least not with KWin).

Therefore, probably, this will be possible only if we all agree that panels that are hidden on overlapping should be shown when the desktop is shown — even when they're overlapped by a pcmanfm-qt's window (which is possible under KWin, because of a bug in it).

@stefonarch
Copy link
Member

FYI: I tested this with xfwm4 - panel shows up here regularly.

@elviosak
Copy link
Contributor

FYI: I tested this with xfwm4 - panel shows up here regularly.

also xfwm4 here, panel stays hidden

@stefonarch
Copy link
Member

stefonarch commented Dec 17, 2021

I see:

But testing again with Alt+D in globalkeys and "show desktop plugin" added panel shows up here.

@elviosak
Copy link
Contributor

Tested here again and it's working without the patch with both shortcuts. No idea why it didn't work before...

@stefonarch
Copy link
Member

Tested in VM Lubuntu 21.04 and LXQt 1.0. with openbox and --- it doesn't work...
Now the VM broke, so I cannot test with xfwm4

Here 2 panel setup, bottom and right.

@tsujan
Copy link
Member

tsujan commented Dec 17, 2021

Tested here again and it's working without the patch with both shortcuts. No idea why it didn't work before...

Each WM has its own way (its own X11 code) for "Showing Desktop". With KWin, the panel state doesn't change because the overlapping state doesn't change. With compiz-reloaded, the panel is always shown on showing desktop.

@stefonarch
Copy link
Member

So I looked again in Lubuntu with LXQt 0.17 and the showdesktop shortkey works fine with xfwm4 but not with openbox, neither the LXQt one neither the one from openbox, as in this issue report described.

@maoamid
Copy link
Author

maoamid commented Dec 19, 2021

Today on Void linux - Lxqt 1.0 & openbox:
(Ctrl+Alt+D does nothing & Super+D toggle show the desktop but not the panel). A screen with configs:
2021-12-19-131900_1366x768_scrot

@stefonarch
Copy link
Member

stefonarch commented Dec 19, 2021

This is what I saw too - panel doesn't show up with openbox, but does with xfwm4.
If you change to Alt+d in globalkeys? Will it at least work to show the desktop?

@tsujan
Copy link
Member

tsujan commented Dec 19, 2021

Shortcut conflicts aside, there should be the show-desktop widget on the panel for it to work.

@maoamid
Copy link
Author

maoamid commented Dec 19, 2021

Shortcut conflicts aside, there should be the show-desktop widget on the panel for it to work.

Thanks @tsujan for the hint, but even if the show-desktop widget is active on the panel, when the show-desktop keys are pressed the panel remain hidden when "hide only on overlapping window" is on, this is what this issue is about.

Partially true: panel is a key component in lxqt desktop manager, true, but a show-desktop global key functionality must not be compromised by adding or not a widget on it, beside that all required libs are installed, so the global key must remain functional no matter what, my point of view.

@maoamid
Copy link
Author

maoamid commented Dec 19, 2021

@stefonarch someone seems to raise it like an issue: #1690 recently
Edit: it was you :D, didn't noticed until now, sorry

@maoamid maoamid changed the title show / hide behaviour when using "hide on overlapping window" option show / hide behaviour when using "hide only on overlapping window" option Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants