Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to Ansible Collection #7

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Refactoring to Ansible Collection #7

wants to merge 33 commits into from

Conversation

mkbrechtel
Copy link
Contributor

@mkbrechtel mkbrechtel commented May 18, 2024 •
edited
Loading

Refactoring of the repo to an Ansible Collection.

We now have three roles that basically do the same that the old playbooks did.

The ansible collection is now on top level of the repo.

Also i provided a playbook to recreates the terraform test environment for fast development iteration.

@mkbrechtel
move terraform files to test folder
891f239 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel mkbrechtel marked this pull request as draft May 18, 2024 12:34
@mkbrechtel mkbrechtel mentioned this pull request May 18, 2024
Open
@mkbrechtel
add ansible collection repo files
a357dc6 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
Copy link
Contributor Author

mkbrechtel commented May 18, 2024 •
edited
Loading

I will first proceed on putting the 3 playbooks for ceph, ovn and incus into 3 roles named the same. We might split that up later, but i first want to do the refactoring without changing the original logic.

@mkbrechtel mkbrechtel changed the title WIP: move terraform files to test folder WIP: Refactoring to Ansible Collection May 18, 2024
@mkbrechtel
move ansible files to place in the ansible collection file structure
274df29 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
rename task_ variables to their respective role names
3a22e38 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
refactor ceph playbook to ansible role files
4183371 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
refactor incus playbook to ansible role files
2358973 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
refactor ovn playbook to ansible role files
405903c 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
refactor hosts example file as a test inventory directory
329fb10 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
split ansible readme to readme for each role
0697282 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
rewrite central deploy playbook and ansible config for new structure
54e956a 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
adjust readme to be compatible with the new structure
bf27cdf 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
fix task indent
bb35a70 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
let ansible output yaml instead of json for better readability
a419cbd 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
set ceph template paths correctly
87a4169 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
fix data directory path
b6a0e68 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
rename ceph template files
7a45437 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
fix ceph source template var names
8b0d3d7 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
fix variable names in templates
23f2e38 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
fix paths in ceph role and comment apt handler invocation
cd1266f 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
add a playbook to simply rerun the test project
5173246 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
ignore one of the terraform state files
9877152 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
rename ovn templates and fix task paths
b689d52 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
recreate all folders on test rerun
163af2b 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
disable ovn and incus in test playbook for now
5344feb 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
rename playbook that recreates the test env
ea479bf 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
fix handler invocation
e6ef89d 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
fix recreation playbook ovn data directory
ba8dcac 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
enable ovn and incus deploy again
af2fa1e 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
rename all remaining templates and rename all tpl extension usages to j2
6668174 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
fix wrong ovn default var
fd8e990 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
symlink template from ovn role that is also needed in incus role
1ddbad8 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
Wait for IPv6 address to be set to avoid a race condition when starti…
cf2bfb2 
…ng the deploy playbook right after the recreation playbook

Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
fix some data paths in the task file
e3087af 
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
Copy link
Contributor Author

mkbrechtel commented May 19, 2024 •
edited
Loading

Ok, this seems to have done it. The setup now runs on my server and from what i can tell everything works.

I think we still need to do some restructuring, but this brings everything in collection form and preserves the original logic.

This is a good point to merge now so we can iterate upon this.

@mkbrechtel mkbrechtel marked this pull request as ready for review May 19, 2024 14:05
@mkbrechtel mkbrechtel changed the title WIP: Refactoring to Ansible Collection Refactoring to Ansible Collection May 19, 2024
@stgraber
Copy link
Member

Hey, just to let you know that I'm not ignoring this :)

I've looked through it a couple of times so far and got a bit overwhelmed by it and have been crazy busy with other work so haven't had the time to start picking things up from this and merging, sorry!

@mkbrechtel
Copy link
Contributor Author

mkbrechtel commented Jul 17, 2024 •
edited
Loading

Hey, just to let you know that I'm not ignoring this :)

I've looked through it a couple of times so far and got a bit overwhelmed by it and have been crazy busy with other work so haven't had the time to start picking things up from this and merging, sorry!

Thank you! :)

I reviewed your latest changes, i am trying on getting the refactoring-branch to include all those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkbrechtel @stgraber