Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Manticore and use Schema Registry client to check schemas #139

Open
andsel opened this issue Feb 10, 2023 · 0 comments
Open

Avoid Manticore and use Schema Registry client to check schemas #139

andsel opened this issue Feb 10, 2023 · 0 comments
Assignees

Comments

@andsel
Copy link
Contributor

andsel commented Feb 10, 2023

During the registration of the Kafka input, if schema registry is required, the plugins does some checks and uses the ReST API, using Manticore to issue the requests:
https://github.com/logstash-plugins/logstash-integration-kafka/blob/0462434fc6cf2c1de0d9314bbeb0c0840473d223/lib/logstash/plugin_mixins/kafka/avro_schema_registry.rb#LL71C16-L71C25

Avoid to use Manticore and leverage to the SchemaRegistryClient class to execute those checks.
This client is already bundled:

implementation("io.confluent:kafka-schema-registry-client:${confluentKafkaVersion}") {

@andsel andsel self-assigned this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant