Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver validation during execute_statement delays library path validation #362

Open
jsvd opened this issue Nov 7, 2019 · 0 comments
Open
Labels

Comments

@jsvd
Copy link
Member

jsvd commented Nov 7, 2019

The plugin only loads the driver(s) during open_jdbc_connection, that is executed with execute_statement.

Because of this, if the file passed to jdbc_driver_library doesn't exist, an error only happens when the scheduler triggers for the first time.

Also, the execute_statement adquires the connection_lock but if the open_jdbc_connection raises an exception the lock isn't released, causing logstash to deadlock during shutdown in close_jdbc_connection

@jsvd jsvd added the bug label Nov 7, 2019
kares added a commit to kares/logstash-input-jdbc that referenced this issue Jan 21, 2020
kares added a commit to logstash-plugins/logstash-integration-jdbc that referenced this issue Jan 22, 2020
these are non-critical improvements for (input) driver loading.

issues are kept on the original repo since they concern the plugin.
this is expected to resolve logstash-plugins/logstash-input-jdbc#369
(also partially relates to logstash-plugins/logstash-input-jdbc#362)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant