You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I like this (though I would quibble pointlessly about that subtitle markup 😀). I have two additional suggestions:
add another variable, node, to the module's hook_theme implementation for this block, then populate it with the node object. This will make it simple, in themes, to override the rendering of the block according to content type (and according to the node content itself),
add template suggestions for the content type to the block template (maybe using EntityTypeBundleInfo() in hook_theme_suggestions_HOOK()...not sure if we would want to limit this to LGD content types, or just catch them all),
The fact that what might be relatively simple things to handle in themes spawn issues like consider stacked h1 pattern for guides, and that (as you pointed out) localgov_publications uses a different block suggest to me that the core block could be more helpful specifically w/r/t the current content type.
I'd be well in favour of this. I'm pretty sure it'd let us get rid of the header block that localgov_publications has in favour of just using the existing one with a template and some preprocess. It'd also simplify some of the theme work we've done on H&F.
Originally posted by @ctorgalson in #193 (comment)
As it can be used on any entity, perhaps entity type and bundle type.
The entity is already part of the block so can be added to the template.
The text was updated successfully, but these errors were encountered: