Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast parse error; sret paramter attribute #8

Closed
pupiles opened this issue May 16, 2021 · 5 comments
Closed

ast parse error; sret paramter attribute #8

pupiles opened this issue May 16, 2021 · 5 comments

Comments

@pupiles
Copy link

pupiles commented May 16, 2021

Hi,
i test other .ll file by remove the sret() attr,but some of them still throw errors
test1.zip
may be these are not the features of llvm12?

@mewmew
Copy link
Member

mewmew commented May 16, 2021

may be these are not the features of llvm12?

Yeah, I think this was introduced in LLVM 12.

ref: https://github.com/llir/llvm/blob/9cc56640dd8f366c6aa61ed01496f2dc18f1b90f/llvm12.diff#L1063

+    case lltok::kw_sret: {
+      Type *Ty;
+      if (parseRequiredTypeAttr(Ty, lltok::kw_sret))
+        return true;
+      B.addStructRetAttr(Ty);
+      continue;
+    }

@mewmew
Copy link
Member

mewmew commented May 16, 2021

@pupiles, for the future, please create issues on the llir/llvm repository. We try to track all issues related to llir in the llir/llvm repo, so we can add labels and track them collectively.

Cheers,
Robin

@pupiles
Copy link
Author

pupiles commented May 16, 2021

Yeah, the sret attr is the feature in llvm 12, so i remove the sret attr in my .ll file ,i mean the file in test1.zip occurs error seems not llvm 12 features.
thanks for your suggestion,i will create issues in llir/llvm later.

@mewmew
Copy link
Member

mewmew commented May 16, 2021

i mean the file in test1.zip occurs error seems not llvm 12 features.

If so, please report the errors (that are not LLVM 12 features), so we can fix them :)

@mewmew
Copy link
Member

mewmew commented May 16, 2021

Tracked by llir/llvm#169. Closing this issue to keep tracking in one place.

@mewmew mewmew closed this as completed May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants