Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urgent: Latest LFortran update broke all compilation #50

Closed
certik opened this issue Nov 23, 2022 · 6 comments · Fixed by lfortran/lfortran#1034
Closed

Urgent: Latest LFortran update broke all compilation #50

certik opened this issue Nov 23, 2022 · 6 comments · Fixed by lfortran/lfortran#1034
Assignees

Comments

@certik
Copy link
Contributor

certik commented Nov 23, 2022

Here is how it currently looks like:

Screen Shot 2022-11-22 at 7 44 03 PM

This happened after I merged #49. The preview looked ok, but all the template stuff (as implemented in lfortran/lfortran#1021) also didn't work, but at least Mandelbrot worked. It almost looked like if LFortran didn't properly updated in the preview.

For now I tried to fix this by reverting the latest deploy in: fe6038d.

But it still didn't fix it for me. I have no idea why.

@Shaikh-Ubaid do you think you could please investigate? I have no idea what is going on. Reverting the gh-pages should fix it, but it didn't.

@certik
Copy link
Contributor Author

certik commented Nov 23, 2022

I tested in a private browser window and it seems it works again. Perhaps it only broke temporarily after all.

@Shaikh-Ubaid can you test it and see if it works for you?

If so, then it's not urgent. Something still broke and we'll have to investigate, but it's not urgent.

@Shaikh-Ubaid
Copy link
Member

I am looking into it.

@Shaikh-Ubaid
Copy link
Member

Shaikh-Ubaid commented Nov 23, 2022

But it still didn't fix it for me. I have no idea why.

@Shaikh-Ubaid do you think you could please investigate? I have no idea what is going on. Reverting the gh-pages should fix it, but it didn't.

@Shaikh-Ubaid can you test it and see if it works for you?

I think, the reverting worked. For me, dev.lfortran.org works

image

@Shaikh-Ubaid
Copy link
Member

I think I figured the solution. Fix incoming.

@Shaikh-Ubaid
Copy link
Member

This happened after I merged #49. The preview looked ok, but all the template stuff (as implemented in lfortran/lfortran#1021) also didn't work, but at least Mandelbrot worked. It almost looked like if LFortran didn't properly updated in the preview.

I shared about it here #49 (comment)

@Shaikh-Ubaid
Copy link
Member

Shaikh-Ubaid commented Nov 23, 2022

We are unable to update the commit at the moment. The repository https://github.com/lfortran/wasm_builds is not building. Thus the lfortran.js/wasm/data files are not available to be downloaded by the build.sh script.

Upcoming Steps:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants