Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] : Flowing github star counter in header #31

Open
xuelink opened this issue Feb 20, 2024 · 18 comments · Fixed by #58
Open

🐛 [BUG] : Flowing github star counter in header #31

xuelink opened this issue Feb 20, 2024 · 18 comments · Fixed by #58
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@xuelink
Copy link
Member

xuelink commented Feb 20, 2024

Describe the bug
Flowing github star counter

Expected behavior
It should stick to theme toggle

Screenshots
Simulator Screenshot

Smartphone (please complete the following information):
iPhone SE

Additional
Related with #20

If you want speed up process of this issue, please send 🚀 as a reaction.

@xuelink xuelink added the bug Something isn't working label Feb 20, 2024
xuelink added a commit that referenced this issue Feb 20, 2024
@neebooo
Copy link
Contributor

neebooo commented Feb 21, 2024

Can you assign this to me please

@xuelink xuelink assigned xuelink and neebooo and unassigned xuelink Feb 21, 2024
@xuelink
Copy link
Member Author

xuelink commented Feb 21, 2024

Can you assign this to me please

Done! Thank you for interest.

@xuelink xuelink added the good first issue Good for newcomers label Apr 4, 2024
@xuelink
Copy link
Member Author

xuelink commented Apr 13, 2024

Can you assign this to me please

We miss you @neebooo :) Please, tell me if you can't have time to to that, let me do this issue free to be assignable.

@xuelink xuelink added this to Backlog Apr 13, 2024
@xuelink xuelink moved this to Todo in Backlog Apr 13, 2024
@xuelink
Copy link
Member Author

xuelink commented Apr 16, 2024

I think you can fix this bug @jakebogan01 , let me know if you want to be assigned this issue as well
Best

@jakebogan01
Copy link
Contributor

@xuelink Yeah I can try this one. Let me finish the footer issue first and then I can attempt this issue next

@jakebogan01
Copy link
Contributor

@xuelink I have viewed the website on all major browsers, mobile and desktop. I can't replicate this bug, nor do I even see the GitHub star in general. Is this still an issue somehow?

@xuelink
Copy link
Member Author

xuelink commented Apr 18, 2024

@jakebogan01

1fd35cd0-859f-4a78-822e-9f464619ce19.mp4

@xuelink
Copy link
Member Author

xuelink commented Apr 18, 2024

You may play with CSS to make github icon and number horizontally instead of vertically, it may fix 😉

@jakebogan01 jakebogan01 moved this from Todo to In Review in Backlog Apr 18, 2024
@jakebogan01
Copy link
Contributor

@xuelink Thank you for the video, I was testing on the live site. I didn't know it was commented out.

I made a PR for this issue here

@xuelink xuelink closed this as completed Apr 18, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Backlog Apr 18, 2024
@xuelink
Copy link
Member Author

xuelink commented Apr 18, 2024

@jakebogan01 did you check with big numbers :D something like more than 1000+, is it gonna be 1K :D we will be soon hope :)

@jakebogan01
Copy link
Contributor

jakebogan01 commented Apr 18, 2024

@xuelink Yes, I made sure that it can contain as many numbers as needed. I also made sure that a comma will be in place for example: 45,000

Maybe down the line we can write some logic that replaces 4,000 with 4k and so on. But for now it'll show 4,000

@xuelink
Copy link
Member Author

xuelink commented Apr 18, 2024

Screenshot 2024-04-18 at 10 19 50 PM
https://api.github.com/repos/appwrite/appwrite?page=$i&per_page=100

its ok, np :) thank you! @jakebogan01 hope we will see these days as well :)

@jakebogan01
Copy link
Contributor

No problem, hope so haha

@xuelink xuelink linked a pull request Apr 19, 2024 that will close this issue
@xuelink
Copy link
Member Author

xuelink commented Apr 24, 2024

I realized with links like cookies or other pages, github star counter doesnt work, but with /blog it works @jakebogan01

githubstar.mp4

@xuelink xuelink reopened this Apr 24, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Backlog Apr 24, 2024
@jakebogan01
Copy link
Contributor

@xuelink that's weird. I never moved any of the api fetch logic, I only added the github icon. I did move the github count from outside the icon to inside of it but that shouldn't have broken it. I'll take a look and see what I can find out about that

@jakebogan01
Copy link
Contributor

@xuelink Locally, the github stars works on all pages, blogs, privacy, terms and cookies and so on. But on the live website, cookies is the only page that its not working for me. Not sure why, I don't even see a status code in the network tab

@xuelink
Copy link
Member Author

xuelink commented Apr 24, 2024

@xuelink Locally, the github stars works on all pages, blogs, privacy, terms and cookies and so on. But on the live website, cookies is the only page that its not working for me. Not sure why, I don't even see a status code in the network tab

@DH-555 What do you think about that ? Maybe its related with Cloudflare :/ i have no idea

@DH-555
Copy link
Contributor

DH-555 commented Apr 24, 2024

No idea, will check by the weekend, but it seems that it's not being made any request in that specific page in order to fetch the data from GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants