Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to delete node by apply #4936

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

yangxggo
Copy link
Contributor

fix #4869

when delete node via seaos apply -f Clusterfile, the target node will not exist in the Clusterfile, in that case, if the node has a different passwd with other nodes, the scale down process will failed.

my solution is passing the 'current' clusterfile when NewScaleProcessor, it will not affect the sealos add and sealos delete because the add and delete processes pass current clusterfile originally. It will only affect the sealos apply when it comes scale process.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Jul 31, 2024

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1272
✅ Successful 367
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 902
❓ Unknown 0
🚫 Errors 2

Errors per input

Errors in docs/4.0/i18n/zh-Hans/examples/blog-platform/install-halo.md

Errors in docs/4.0/docs/examples/blog-platform/install-halo.md

Full action output

Full Github Actions output

Copy link
Collaborator

@cuisongliu cuisongliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test

@cuisongliu cuisongliu merged commit 76990af into labring:main Sep 20, 2024
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to delete node
3 participants