ignore_after: patch Task.cancel to separate timeout vs external cancel #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #44
This is my patch from #44 (comment), and a unit test based on the opening post in that thread.
I have tried to make the test not too dependent on timing - experimentation suggests it is very reliable, it did not fail during any of my runs.
Note:
timeout_after
is also affected. Should I include a unit test for that too? Not sure how to avoid duplicating the code but I could try.