Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOCKS over Unix sockets #39

Open
JeremyRand opened this issue Mar 25, 2021 · 2 comments · May be fixed by #40
Open

SOCKS over Unix sockets #39

JeremyRand opened this issue Mar 25, 2021 · 2 comments · May be fixed by #40

Comments

@JeremyRand
Copy link
Contributor

It would be useful to support SOCKS over Unix sockets (not just IP sockets). This is considered a best practice for security-related software, as it makes sandboxing much easier. Would a PR for this be accepted?
@JeremyRand
Copy link
Contributor Author

JeremyRand commented Mar 25, 2021 •
edited
Loading

It looks like I'd want to edit util.py to add a UnixAddress that's similar to NetAddress but only accepts one argument in its constructor (the Unix socket path), and then make socks._connect_one support UnixAddress as an alternative to NetAdddress. Is that a sane approach?

@kyuupichan
Copy link
Owner

I have no objection. Adding support for any network protocol should be easy as none is assumed in the socks code; it just deals in byte streams.

JeremyRand added a commit to JeremyRand/aiorpcX that referenced this issue Apr 8, 2021
@JeremyRand
Support SOCKS over Unix domain sockets
ebe2f66 
Fixes kyuupichan#39
@JeremyRand JeremyRand linked a pull request Apr 8, 2021 that will close this issue
Open
JeremyRand added a commit to JeremyRand/aiorpcX that referenced this issue Apr 30, 2021
@JeremyRand
Support SOCKS over Unix domain sockets
7910789 
Fixes kyuupichan#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support SOCKS over Unix domain sockets JeremyRand/aiorpcX
2 participants
@JeremyRand @kyuupichan