fix(controller): include services that have pods labled injection as part of mesh #12005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…part of mesh Signed-off-by: Jay Chen <[email protected]>
jijiechen
requested review from
bartsmykla and
Icarus9913
and removed request for
a team
michaelbeaumont
requested changes
Nov 11, 2024
There was a problem hiding this comment.
It's not clear to me that we want to do this. We are trying to break the Pod controls Service logic we've had up until now.
Most of the time there's a Deployment/StatefulSet/DaemonSet controlling these Pods with the Pod template setting these labels. Why wouldn't the user also be able to set a label on the Service?
|
I agree with Mike we're trying to part with this dependency. Folks should either label their entire namespace or all entities independently |
|
As per triage, we don't update the behaviour in Kuma but update the doc website, so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve reconciler of service controller
Implementation information
Detect if there is at least one pods of the service is labeled "kuma.io/sidecar-injection=enabled"
Supporting documentation
fixes #11994